meliorence / react-native-render-html

iOS/Android pure javascript react-native component that renders your HTML into 100% native views
https://meliorence.github.io/react-native-render-html/
BSD 2-Clause "Simplified" License
3.48k stars 589 forks source link

typescript compiler error because of ramda on version 6.3.4 #579

Closed mohameddiopcodes closed 1 year ago

mohameddiopcodes commented 2 years ago

Decision Table

Good Faith Declaration

Description

Using version 6.3.4 to render html formatted text in react native turned out to be a problem. typescript was failing because of ramda causing our CI pipeline to reject pushed changes.

Fix: downgraded to version 5.1.0

React Native Information

ramda causing failure for typescript compiler.

RNRH Version

6.3.4

Tested Platforms

Reproduction Platforms

Minimal, Reproducible Example

install version 6.4.0 of the renderer on a typescript application, run the typescript compiler. Errors should pop up, Ramda is not compatible.

Additional Notes

No response

jsamr commented 2 years ago

@mohameddiopcodes you need to provide as much info as possible for us to help. At a very minimum, explain how you came up to the conclusion Ramda typings were faulty, and show the TS messages. I'm very bandwidth limited, and won't investigate issues unless they are easy to reproduce with a git/snack reproduction. Having no idea of the Typescript version used or the package manager makes it impossible to guarantee a reproduction locally.

Ramda ships no types, so the issue would eventually raise from @types/ramda, https://www.npmjs.com/package/@types/ramda Also note that there are ways with yarn and npm to override the version used by a dependency, so that shouldn't be strictly blocking for you.

jsamr commented 1 year ago

Closing now, feel free to reopen after providing a reproducible example.