search

meliorence / react-native-snap-carousel

Swiper/carousel component for React Native featuring previews, multiple layouts, parallax images, performant handling of huge numbers of items, and more. Compatible with Android & iOS.
BSD 3-Clause "New" or "Revised" License
10.37k stars 2.29k forks source link

fix: undefined View propTypes issue #820

Closed capelski closed 3 years ago

capelski commented 3 years ago

Platforms affected

Google Chrome on Windows

What does this PR do?

Fix propTypes issues on browsers

What testing has been done on this change?

Launched the app in the Expo Client

justinkchen commented 3 years ago

thanks for this! would be great to get this bumped and merged in! thanks!

FINKITT-PTY-LTD commented 3 years ago

Yeah agreed, the merge would make my day guys!

jaredswenson commented 3 years ago

This works well, can we get a merge please?

JijoBose commented 3 years ago

Thanks, @capelski,
waiting for this to be merged 🚀

BlameFelix commented 3 years ago

This works, however I think the underlying problem is this. After applying the fix from the linked comment web also works fine for me.

capelski commented 3 years ago

As mentioned in https://github.com/meliorence/react-native-snap-carousel/issues/779#issuecomment-830824204, React Native deprecated propTypes. I'm closing this PR since it's not aligned with the React Native evolution and I'm creating https://github.com/meliorence/react-native-snap-carousel/pull/836, which removes ViewPropTypes usage instead of mocking it

udemezue01 commented 3 years ago

How do we solve this, I am getting errors too

steveberdy commented 1 year ago

If you want this code in your project instead of the current, broken code, you can npm uninstall react-native-snap-carousel and then npm install git+https://github.com/capelski/react-native-snap-carousel or your own working fork. You don't have to wait for it to be in the official NPM registry.