fix: viewproptypes export from deprecated prop types

meliorence / react-native-snap-carousel

Swiper/carousel component for React Native featuring previews, multiple layouts, parallax images, performant handling of huge numbers of items, and more. Compatible with Android & iOS.

BSD 3-Clause "New" or "Revised" License

10.37k stars 2.29k forks source link

fix: viewproptypes export from deprecated prop types #929

Open yadigarbz opened 2 years ago

yadigarbz commented 2 years ago

Platforms affected

iOS & Android Referencing RN Issue #33734

What does this PR do?

Fixes issue #928

What testing has been done on this change?

All occurrences of ViewPropType import is changed to react-native's new deprecated-react-native-prop-types repo Nothing to test

Tested features checklist

[ ] Default setup (example)
[ ] Carousels with and without momentum enabled (prop enableMomentum)
[ ] Vertical carousels (prop vertical)
[ ] Slide alignment (prop activeSlideAlignment)
[ ] Autoplay (prop autoplay)
[ ] Loop mode (prop loop)
[ ] ScrollView/FlatList carousels (prop useScrollView)
[ ] Callback methods
[ ] ParallaxImage component
[ ] Pagination component
[ ] Layouts and custom interpolations

abehoffman commented 2 years ago

Any idea when this might be merged?

yadigarbz commented 2 years ago

Any idea when this might be merged?

Unfortunately no

Akeuuh commented 2 years ago

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

yadigarbz commented 2 years ago

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

A patch might also be created from my change list if you like. It would be really nice if a maintainer could have looked at it @bd-arc

Akeuuh commented 2 years ago

Seems like it can take a lot of time hehe

BossBele commented 2 years ago

To solve the issue temporarily, I have forked this branch and merged it into the fork's master. You can install like:

NPM

npm i git+https://github.com/LarvenLLC/react-native-snap-carousel.git

YARN

yarn add git+https://github.com/LarvenLLC/react-native-snap-carousel.git

Until when the PR is merged.

amerikan commented 2 years ago

@Anthony-Buisson @bd-arc can you please merge this 🙏🏼

galaxyreal commented 2 years ago

This helped me to solve the issue.

batazo commented 1 year ago

The react-native-new-snap-carousel available on npm https://www.npmjs.com/package/react-native-new-snap-carousel https://github.com/bzozoo/react-native-new-snap-carousel

aleksandarbos commented 1 year ago

praying to the champions of react-native-snap-carousel realm to merge this pr 🙏