ViewPropTypes has been removed from React Native

meliorence / react-native-snap-carousel

Swiper/carousel component for React Native featuring previews, multiple layouts, parallax images, performant handling of huge numbers of items, and more. Compatible with Android & iOS.

BSD 3-Clause "New" or "Revised" License

10.37k stars 2.29k forks source link

ViewPropTypes has been removed from React Native #962

Open shakeel0581 opened 2 years ago

shakeel0581 commented 2 years ago

Platforms affected

ViewPropTypes has been removed from React Native.

What does this PR do?

Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.

What testing has been done on this change?

Tested features checklist

[ ] Default setup (example)
[ ] Carousels with and without momentum enabled (prop enableMomentum)
[ ] Vertical carousels (prop vertical)
[ ] Slide alignment (prop activeSlideAlignment)
[ ] Autoplay (prop autoplay)
[ ] Loop mode (prop loop)
[ ] ScrollView/FlatList carousels (prop useScrollView)
[ ] Callback methods
[ ] ParallaxImage component
[ ] Pagination component
[ ] Layouts and custom interpolations

samih-sghier commented 2 years ago

can this be merged/deployed?

yousrasd commented 2 years ago

Please, can we merge this branch and include it in an official release? We are dependent on this lib in our project, and we can't proceed with the upgrade to ReactNative 0.70 due to this ViewPropTypes dependency.

LG1710 commented 1 year ago

Hello, could you merge this PR in the master and make a new tagged version, thx

romchambe commented 1 year ago

👍 to merge this PR and publish a new version 🙏 This is completely blocking for RN 0.69

interstates21 commented 1 year ago

Why it's still not merged?

diogobas commented 1 year ago

@meliorence please, merge it when you get a chance.

batazo commented 1 year ago

Use React Native New Snap Carousel https://www.npmjs.com/package/react-native-new-snap-carousel https://github.com/bzozoo/react-native-new-snap-carousel

tendaimaswaya commented 1 year ago

It might be safe to say there's no future for this current package. It seems to have taken eons to merge and publish something that's already been implemented.