fix viewPropsTypes - Githubissues

meliorence / react-native-snap-carousel

Swiper/carousel component for React Native featuring previews, multiple layouts, parallax images, performant handling of huge numbers of items, and more. Compatible with Android & iOS.

BSD 3-Clause "New" or "Revised" License

10.37k stars 2.29k forks source link

fix viewPropsTypes #964

Open pallavi000 opened 1 year ago

pallavi000 commented 1 year ago

Platforms affected

What does this PR do?

What testing has been done on this change?

Tested features checklist

[ ] Default setup (example)
[ ] Carousels with and without momentum enabled (prop enableMomentum)
[ ] Vertical carousels (prop vertical)
[ ] Slide alignment (prop activeSlideAlignment)
[ ] Autoplay (prop autoplay)
[ ] Loop mode (prop loop)
[ ] ScrollView/FlatList carousels (prop useScrollView)
[ ] Callback methods
[ ] ParallaxImage component
[ ] Pagination component
[ ] Layouts and custom interpolations

alissonbovenzo commented 1 year ago

this source fixed my problem too

Kaito-Dogi commented 1 year ago

Thank you for everything! react-native-snap-carousel has delivered the best experience to our users. We are experiencing the same error with our app and would love to have this pull request merged. When will the version including this pull request be available?

Exilz commented 1 year ago

Hi, I’d be glad to merge a simple PR that fixes the ViewPropTypes (and only those). However, the PR you linked changed the whole code and the way it’s formatted. Because of that, I cannot review it with a quick glance. Would you be able to open a PR that fixes only that? With as little code change as possible.

If you could do that and send me the PR, we could get this to master ASAP.

gokuls99 commented 1 year ago

@hishamhadraoui @santisilva @jonatan-blossom
Hi Guys, Someone please initiate to merge and make it available in npm. It will be really useful for us.

rodrigoperaltarabbit commented 1 year ago

@Exilz please, now you can merge this. for the community !

FR073N commented 1 year ago

Could you please tell us what is missing for you to merge it ? react-native-snap-carousel is one of the best plugin, and we should keep it alive.