search

melipass / lastfm-to-markdown

GitHub Actions workflow that automatically updates the covers from your last.fm's weekly chart everyday, inside your profile repository's README.md file. Useful for customizing your profile in repos named after your GitHub username.
MIT License
37 stars 4 forks source link

Add link to album in last.fm on album picture #1

Closed HelloYeew closed 2 years ago

HelloYeew commented 2 years ago

Hi! I use your workflow for a while now and I think that it's better if someone curious that what's the album and currently when we click on the album it will send you to the image file.

CleanShot 2565-02-25 at 11 57 37@2x

So I think that why we just add the link to the last.fm page on that album and when someone curious what's album there so just click that album.

CleanShot 2565-02-25 at 11 59 07

New parameter

To make this as an optional option I add INCLUDE_LINK parameter to the setup. It's optional and the default value is false so if you want to enable the link just add INCLUDE_LINK: true to the setup. I have updated setup detail on readme.

Result sample

I release the tag on my fork and try it on my profile repository so you can see the sample result from here. The visual is the same as before add the link.

About the code, I test on INCLUDE_LINK value and it's return as true or false as string so I need to make the condition as os.getenv('INCLUDE_LINK') == 'false'.

melipass commented 2 years ago

Hey @HelloYeew, thank you so much for this PR! I'm really sorry for not noticing your contribution until now, I haven't had much time to keep track of things outside work or uni 🙇‍♀️

This is a great addition, I'll merge your code and create a new version (I see you used 1.3.1, I'll do the same), thanks! 🥰 I'm really happy to see you using this workflow in your profile, by the way. I hope you find it useful.