Open JAVAB3ANS opened 2 years ago
Hey @JAVAB3ANS, I love your changes! I know of several last.fm collage generators that add that text, but I didn't think about doing it for this project before, it's a great idea 😁
I don't have much free time right now, so I'll be able to take a deeper look at the code in a week or two. I actually like to have small covers in my profile, but it's just a personal preference and it would be great to add a variable to the .yml file to activate your changes. Feel free to open a pull request for this if you want.
Thank you so much for sharing this!
@melipass Yeah thanks so much! I'm nearly done with the current updates, but do let me know what you think before we can pull request!
Cheers,
@JAVAB3ANS
Hey! This project is pretty sick so on behalf of us music fans, I decided to make it so it would output 8 images (medium-sized) with white captions like how Last.FM collages generally do it so the cover wouldn't render in such a poor resolution for captions at the smallest size.
Here's how lastfmweekly.yml would look:
Here's how lastfm.py would look
For dependencies.txt, we'd only need to download one more module:
Here's how it would look on my end. Assuming that each album I've listened to has a Lastfm page, I've removed the
if os.getenv("INCLUDE_LINK") == "false":
portions and action.ymlThanks a lot for looking at this, and I hope that I contributed in a constructive manner!