melisgl / named-readtables

The official repo of named-readtables.
Other
66 stars 15 forks source link

Fixed DEFINE-API macro issue on CMUCL. #11

Closed alex-gutev closed 4 years ago

alex-gutev commented 6 years ago

Fixed issue #9 when compiling named-readtables on CMUCL. The issue was caused by an assertion failure in the DEFINE-API macro, when checking the types of the optional parameters, namely the assertion which checks that either the OPTS list is empty or begins with &OPTIONAL. The reason for the assertion failure was that it was placed in the INITIALLY clause of the LOOP however the INITIALLY clause was being evaluated after the FOR variable initialization forms. The fix is to move the assertion out of the LOOP macro. I tested the fix on CMUCL 21c and named-readtables is loaded successfully using QL:QUICKLOAD.

melisgl commented 4 years ago

Thanks. Merged by hand in b7eeb3fb0ce6d591ea8dbd6490a4efc35a9873f4.