melishev / strapi-plugin-react-editorjs

📝 Plugin for Strapi Headless CMS, hiding the standard WYSIWYG editor on Editor.js
https://www.npmjs.com/package/strapi-plugin-react-editorjs
MIT License
171 stars 80 forks source link

Fix bug missing some attributes on image component #45

Open nhvu1988 opened 2 years ago

nhvu1988 commented 2 years ago

As I think the image block shoulds contain the original Strapi image information such as alternativeText, name, ext, provider_metadata ... instead of removing or customizing it. So it keeps the consistent with other plugins that may use them.

melishev commented 2 years ago

@nhvu1988 This change will significantly increase the size of the content. Need to get more attention from other people who need these changes

SalahAdDin commented 2 years ago

@nhvu1988 This change will significantly increase the size of the content. Need to get more attention from other people who need these changes

At least the preview URL is very important for improving SEO(in NextJS, for instance).

So, what could be a better solution?

However, it seems the Cloudinary plugin is not saving the previewURL.

bmfs commented 2 years ago

Maybe adding an option to the plugin config to include the metadata could be a good compromise on the concern of the increased content size.

melishev commented 2 years ago

Maybe adding an option to the plugin config to include the metadata could be a good compromise on the concern of the increased content size.

@bmfs This could be a solution, can you prepare these changes?