melissawm / sphinx-tags

A tiny Sphinx extension that implements blog-style tags for documentation.
https://sphinx-tags.readthedocs.io/en/latest/
MIT License
44 stars 11 forks source link

Add automated tests #59

Closed JWCook closed 10 months ago

JWCook commented 1 year ago

Closes #38

Test setup

Coverage

Test coverage has been added for:

JWCook commented 1 year ago

@melissawm I believe this PR is ready to go. This depends on merging #57 first, so once that's done I can rebase this one.

JWCook commented 10 months ago

I rebased this on top of main, so this is ready to go.

melissawm commented 10 months ago

Running pytest on this with Python 3.12, Sphinx 7.2.6, pytest 7.4.3 I get

  /home/melissa/projects/sphinx-tags/test/conftest.py:18: RemovedInSphinx90Warning: 'sphinx.testing.path' is deprecated. Use 'os.path' or 'pathlib' instead.

This is not a blocker though - we could put this in and deal with the deprecation later.

JWCook commented 10 months ago

Hmm, I originally tried pathlib, but using sphinx.testing.path seemed to be required for Sphinx<=6. You can create another issue for that if you want, and I can look into it some more later.

melissawm commented 10 months ago

I'm not going to say I understand all details but I do get the overall idea and I see zero reasons to hold this off - thank you so much for being patient and sticking with it! I have a few more details to sort and should be cutting a release later this weekend. Cheers!