search

melistik / vaadin-grid-util

simplify the use of vaadin's grid and add features
https://vaadin.com/directory/component/gridutil
MIT License
32 stars 21 forks source link

Vaadin 8 #37

Closed nikkijuk closed 7 years ago

nikkijuk commented 7 years ago

Is is planned that this add on would be ported to vaadin 8?

kabrender commented 7 years ago

Hello, is a port to vaadin 8 in planing?

melistik commented 7 years ago

Yes is in planning - i've already started but it's a huge rebuild because the main features of Container-Filtering is getting removed :)

kabrender commented 7 years ago

Hello, thank you for your quick reply.

Mit freundlichen Grüßen

Karl-Heinz Brender Dipl. Informatiker Senior Software-Entwickler

Barth Medienhaus GmbH Wolfsmatten 1 D-77955 Ettenheim

Tel.: 07822/4447-12 Fax: 07822 4447-28 brender@medien-haus.de http://www.medien-haus.de/

Geschäftsführer: Manfred Barth, Marcel Barth Registergericht Freiburg: HRB 400388 Ust.-Id.-Nr.: DE 192 439 723

Diese E-Mail und alle mit gesendeten Dateien sind vertraulich und ausschließlich für den Gebrauch durch den Empfänger bestimmt! This e-mail and any files transmitted with it are confidential intended solely for the use of the addres see!

Von: Marten Prieß [mailto:notifications@github.com] Gesendet: Montag, 27. Februar 2017 16:26 An: melistik/vaadin-grid-util Cc: kabrender; Comment Betreff: Re: [melistik/vaadin-grid-util] Vaadin 8 (#37)

Yes is in planning - i've already started but it's a huge rebuild because the main features of Container-Filtering is getting removed :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

all-sd commented 7 years ago

Is it possible to create a new version with vaadin 8 compatibility package for migration and after that a new version for vaadin 8 grid?

melistik commented 7 years ago

hi, currently the migration is not finished - I have posted some issues to vaadin. their api changes don't allow a normal use as designed in v7. Thats why it will take propably some weeks to get everything running again...

nikkijuk commented 7 years ago

Is vaadin currently containing two grids? v7 and v8 versions? I guess so.. That must create some mess on communication. I have used only V8 version and they've done there there a lot of changes - I wouldn't be suprised if they still have something to fix / redesign even if I think they've done good job and implementation has been pretty stable.

melistik commented 7 years ago

I've started with a separate branch vaadin-8-migration - just to use the v7 version. But I still got some issues. Maybe someone can support me.

I get some JavaScript exceptions (so the Renders don't work correctly) and other columns expect birthDay didn't get displayed (maybe due to the previous error)...

PhineasClick commented 7 years ago

Hi melistik, can we may support you by somehow upvoting for the issues you openend with vaadin?

pethers commented 7 years ago

Happy to help out as well, really miss this plugin when I migrated partly to vaadin8 using com.vaadin.v7 packages. Hard to find a politician in https://www.hack23.com/cia/#!politicianranking/DATAGRID without any filters. Would be awesome with vaadin8 support.

pethers commented 7 years ago

Forked and created a branch https://github.com/pethers/vaadin-grid-util/tree/vaadin8-v7-support , using vaadin-compatibility-server with vaadin7 packages moved to v7. Commented out some code in org/vaadin/gridutil/client/renderer/buttonvalue/AbstractButtonValueConnector.java

// getRpcProxy(RendererClickRpc.class).click(getRowKey(event.getCell() // .getRow()), getColumnId(event.getCell() // .getColumn()), details);

Doing a soft migration to vaadin8 using v7 packages, so above branch will work for a while.

melistik commented 7 years ago

Hey guys,

currently im quite busy and don't use vaadin-8 in any business case that's why I currently cannot help you out. Sorry :(

@pethers I've testes your branch I seams to work but I still get JavaScript errors for each column:

com.vaadin.client.widgets.Grid
SEVERE: Error rendering cell in column 3
com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'v9b' of null

Could your maybe fix it and afterwards I would build an alpha release out of it.

@PhineasClick thanks for your offer but for me vaadin has changed too many thing. This projects has next to migration-version that's not working also a clean upgrade version (only vaadin-8) but in both cases I got stucked. In both cases I got some errors I don't find out what to change... Maybe you can run one of my brunch and ask vaadin to help out.

nikkijuk commented 7 years ago

If one browses release notes of 8.1 alphas & 8.0.X it starts to be evident that Grid is having severe issues with stability, compatibility and new features are coming in which eventually could extend Grid utils functionality.

https://github.com/vaadin/framework/releases

My 2 cents: it could be wise to fork Grid-Util as version 2.0 for vaadin 8.1 - no compatibility libraries - and give it bit time to stabilize and simultaneously try to get existing Grid-Util to function with vaadin 8.X + compatibility libraries.

pethers commented 7 years ago

@melistik will try to resolve the JavaScriptException, problem is that I don't get any errors myself.

Don't see any exception when running selenium test (https://www.hack23.com/jenkins/job/Citizen-Intelligence-Agency-System-Test/2862/consoleFull) or starting vaadin-grid-util-demo.

PhineasClick commented 7 years ago

Are there still any efforts to port this addon to 8.0?

melistik commented 7 years ago

new release published 2.1.0 great thanks to @hitchhiker-jiri he has done a great job