melix / astro4j

Astronomy libraries for Java
Apache License 2.0
28 stars 5 forks source link

Doppler shift animation and panel does not include negative shift #273

Closed stefanoaz closed 5 months ago

stefanoaz commented 5 months ago

Hi Cédric:

On the latest V2.3.3 Dev jSolEx, I noticed when doing panels (see attached), the the doppler shift only shows the positive shift. I'm pretty sure that the shift normally should include both approaching and receding objects (plasma in this case). So, a panel showing frames from 0 to 1.1 angstrom, I think should instead be showing -1.1 to 1.1 angstroms, centered around zero. And I imagine the sweep shouldn't go so far out into the wings as to reach the continuum - but that's a judgment call.

Things like filaments and other eruptions have both rising and falling areas, so I would expect a doppler animation to show both.

Fabulous work on this excellent project - I've been using it most of the day, after making scans this morning.

Steve Sun_090603_20240525_redshift-2

melix commented 5 months ago

Hi Steve!

In fact this is not fully accurate: the animations show shifts from -1 to 1 A, but the panels only show from 0 to 1 (or -1 to 0 depending on where the maximum shift was detected). In addition, in animations there's interpolation between frames, where there's nothing for panels. The reason I've done this this way is that otherwise the panels were fairly large (twice their current size).

I can add an option to tell if you prefer to have the full range though.

stefanoaz commented 5 months ago

Thanks for the additional detail Cédric. I think it would be nice to have a button allowing the full range to be a non-default option. It would be educational at least. I wouldn't call it a high priority, but would be nice to have.

Thanks for the work you have put into this.

Steve

melix commented 5 months ago

This is shipped into 2.3.3, enjoy!

stefanoaz commented 5 months ago

Thanks Cédric, I just downloaded it.

Cheers,

Steve

On May 27, 2024, at 12:02, Cédric Champeau @.***> wrote:

This is shipped into 2.3.3, enjoy!

— Reply to this email directly, view it on GitHub https://github.com/melix/astro4j/issues/273#issuecomment-2133945218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4JHEEGL757VKX2L5KEXVDZEN7NZAVCNFSM6AAAAABIJIKPDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHE2DKMRRHA. You are receiving this because you authored the thread.