search

melix / jmh-gradle-plugin

Integrates the JMH benchmarking framework with Gradle
Apache License 2.0
666 stars 88 forks source link

Feature/update default jmh version #120

Closed imanushin closed 6 years ago

imanushin commented 6 years ago

Several items:

  1. Update dependent components to newer version (gradle runner inclusive)
  2. Use full gradle distribution (to see more hints in IntelliJ Idea)
  3. Update default version of JMH as 1.19 (as written in documentation)
imanushin commented 6 years ago

@melix , would you like to merge or reject my fixes?

imanushin commented 6 years ago

Fixed.

Full distribution is recomended by IntelliJ Idea - https://discuss.gradle.org/t/configuring-gradle-wrapper-to-used-distribution-with-sources-in-intellij-ide/5866

melix commented 6 years ago

Thanks. I know IntelliJ recommends the fat version, but I disagree. They should download the sources instead.

melix commented 6 years ago

There's a build error I need to investigate before I can merge this.

imanushin commented 6 years ago

@melix , I agree with you.

Thanks. I know IntelliJ recommends the fat version, but I disagree. They should download the sources instead.

imanushin commented 6 years ago

@melix , could you please take a look on this pull request ?