search

melix / jmh-gradle-plugin

Integrates the JMH benchmarking framework with Gradle
Apache License 2.0
666 stars 88 forks source link

Ensure that resources are copied last to JAR #131

Closed jdpgrailsdev closed 6 years ago

jdpgrailsdev commented 6 years ago

@melix This PR addresses an issue with a blank BenchmarkList file due to the fact that the generated classes directory includes a blank BenchmarkList file and is winning out over the populated one in the generated resources directory. The PR re-organizes the order of the copy commands for the Gradle JAR task to ensure that the resources directory is copied last (and therefore the populated BenchmarkList is included).

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 34.683% when pulling 482292455ff76687827dc6345ccbac8294368ccc on jdpgrailsdev:jpearlin/correct-jar-include-order into 2b65ad52c2c0a6726595cb6b8f096c82e4097c1d on melix:master.

jdpgrailsdev commented 6 years ago

@melix Looks like the CI build failed for an unrelates reason (the branch builds fine locally for me). Any chance of getting this merged? I am currently relying on a custom build off of my branch and would like to be able to change back to using a proper release. Thanks!

melix commented 6 years ago

Thanks for the PR and sorry for the delay, I'll see if I can release soon.

jdpgrailsdev commented 6 years ago

@melix no worries and thanks for merging this!

melix commented 6 years ago

0.4.7 is out with those changes, thanks again!