Close the amended class loader

melix / jmh-gradle-plugin

Integrates the JMH benchmarking framework with Gradle

Apache License 2.0

666 stars 88 forks source link

Close the amended class loader #149

Closed veita closed 5 years ago

veita commented 5 years ago

Pull request to solve https://github.com/melix/jmh-gradle-plugin/issues/148.

coveralls commented 5 years ago

Coverage decreased (-0.4%) to 46.587% when pulling d4286ffc69589720355a6feac43b8abf02cc86fd on veita:master into cc4d3056a798027bbbc0ac5855e1334270293ffa on melix:master.

veita commented 5 years ago

Catching NoSuchMethodError is due totargetCompatibility=1.6 specified in compile.gradle. Compiling with JDK 1.6 may fail due to the missing close() call in the Java 1.6 class loader.

However, if 1.6 is an error in compile.gradle catching NoSuchMethodError could be left out.

melix commented 5 years ago

Superceded by #4fc4a725080682761eef96a0914b5207351ebc7e