Fix a bug where benchmarkParameters are not respected

melix / jmh-gradle-plugin

Integrates the JMH benchmarking framework with Gradle

Apache License 2.0

662 stars 88 forks source link

Fix a bug where benchmarkParameters are not respected #201

Closed jrhee17 closed 2 years ago

jrhee17 commented 3 years ago

Motivation

Benchmark fails to run due to an extra space

> Task :jmh FAILED
[-bm, thrpt,ss, -foe, 1, -gc, 0,  -p, a=a, -rf, csv, -rff, /private/var/folders/5t/dnxsrx2d3r3c602x4z01t2vw0000gn/T/spock_Executes_benchmarks_0_temporaryFolder6367835791579630067/build/reports/benchmarks.csv]
No matching benchmarks. Miss-spelled regexp?

Modification

Remove the extra whitespace and add a functional test

mkjois commented 2 years ago

@melix I'm running into this as well. Can we get this merged and released?

melix commented 2 years ago

Good catch, thank you!

mkjois commented 2 years ago

@melix Thanks! What's your release schedule like? Just want to get a sense for when I can expect 0.6.6

melix commented 2 years ago

It's out ;)

mkjois commented 2 years ago

Fantastic, amazing plugin too btw!