search

melkypie / ClanChatCountryFlags

Adds country flags to clan chat
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Seperate flag for US West and US East #2

Open PhantomBoat opened 4 years ago

PhantomBoat commented 4 years ago

Amazing plugin! Would it be possible to have separate flags for US East and West?

Maybe the left half of the flag still being the US flag but the right half being a W or E?

melkypie commented 4 years ago

This currently not possible due to there not being a reliable way of detecting whether or not a world is us east or west. Until Jagex adds something like this, I don't believe I can do it

PhantomBoat commented 4 years ago

Would it be possible to have a config file with each server manually assigned location to override location provided by Jagex? And then a checkbox option inside of the plugins settings to enable or disable that list (in case it gets out of date).

I'd be happy to make the config file for you if you and try to keep it updated. I'd offer to help write the code to implement the feature, but I've not messed with programming plugins for RuneLite.

melkypie commented 4 years ago

I wouldn't ever want to go that route and that seems like a terrible solution, also you have to account for Jagex to change the world locations, like they do with bounty hunter/pvp worlds every week. Also config options in Runelite are static not dynamic so if a new world gets added/removed that would be a mess to clean up. If you are wanting to help I would suggest you maybe take the approach of looking up the ip of the world and try to find the us east/west based. Unfortunately I can't do it myself because of school but if you make a PR, I'll be happy to look at it.

Newbcake commented 1 year ago

Now that jagex added different flags for east and west coast would you reconsider this?

YvesW commented 1 year ago

This currently not possible due to there not being a reliable way of detecting whether or not a world is us east or west. Until Jagex adds something like this, I don't believe I can do it

Can be done using client.getEnum(4992) now probably.