search

melloware / coloris-npm

A lightweight and elegant JavaScript color picker.
MIT License
34 stars 9 forks source link

undefined error when reading getBoundingClientRect in updatePickerPosition() #106

Closed admdly closed 1 year ago

admdly commented 1 year ago

There is an error in updatePickerPosition() with the latest (0.19.0) release on npm, which appears to be due to the line added in 9af0f49 not being in the actual npm 0.19.0 release.

Specifically, the release on GitHub includes the following check:

https://github.com/melloware/coloris-npm/blob/9af0f49684b5d50258ad21e792b80d67d42e7a01/src/coloris.js#L351

However, the version hosted at npmjs.com, and downloaded via npm, does not:

Screenshot 2023-04-22 at 20 02 37

This is causing the following error:

Screenshot 2023-04-22 at 19 07 34
blutorange commented 1 year ago

@melloware I checked and the line really is missing in the NPM release. I also did npm pack to build the dist files, and they do contain the line in question, so it's not an issue with the build process. So I guess it must have happened during the release process? We do have a prepack script that regenerates all build files from source files again, so I'm not sure what could have gone wrong. Either, seems like we just have to make a new 0.19.1 release

melloware commented 1 year ago

I think that was my fault. I will release a 0.19.1 shortly.

melloware commented 1 year ago

OK 0.19.1 published if you don't mind checking it out.

admdly commented 1 year ago

Thanks for the quick turn around - I can confirm this fixes the error.

melloware commented 1 year ago

Thanks for reporting and confirming!