search

melloware / coloris-npm

A lightweight and elegant JavaScript color picker.
MIT License
35 stars 9 forks source link

Builds Failing #78

Closed melloware closed 1 year ago

melloware commented 2 years ago

@blutorange Do you mind looking into why the builds are failing? It doesn't look like any code was changed but they seem to be failing

blutorange commented 2 years ago

Looks very interesting, perhaps a new version of the bundler that maks it fail? Let me see...

blutorange commented 2 years ago

Seems there was a change in node's experimental custom ESM loader implementation, had to update yarn. Build should be working now again

melloware commented 2 years ago

You rock!

melloware commented 1 year ago

@blutorange I just pulled in the latest Coloris changes and the build is failing? What is weird is it converted what looks like ES2015 code using const back to var but looking at his main source repo its always been var. Did we change something in the source?

blutorange commented 1 year ago

Do you mean this, which was window.Coloris? We had to change that so that we only expose it globally when not running in a module environment. I don't think I changed anything else. Other than that, it seems that many const were changed to var at some point in the original repo.

https://github.com/mdbassit/Coloris/blob/v0.1.0/src/coloris.js

image

melloware commented 1 year ago

No it was my bad i copied his coloris.js from dist and not from his source.

melloware commented 1 year ago

False alarm