search

melloware / react-logviewer

React Lazy LogViewer
https://melloware.github.io/react-logviewer/
Mozilla Public License 2.0
60 stars 15 forks source link

Support standardized log formats #30

Open lukas-mertens opened 5 months ago

lukas-mertens commented 5 months ago

I think it would be a nice addition if the log viewer would allow parsing standardized log formats, starting with structured json logs. It would be nice to display them in a human readable form, maybe provide a toggle to switch on/off the parsing.

This would also allow merging multiple logs into one logviewer by timestamp. What do you think about such a feature?

If you like it, I would be open to contribute such a feature

melloware commented 5 months ago

PRs are always welcome here!

lukas-mertens commented 5 months ago

@melloware I just had a quick read through the CONTRIBUTING.md. I have a few questions regarding that:

  1. It says that contributions are under MIT license. But the project is licensed under MPL. Is this even compatible? As far as I understand MPL contributions in the same files as MPL can't be MIT as the copyleft clause would be lost
  2. It says that contributions are only to be done by individuals. What about employers which give their employees a certain amount of time to work on open source projects during work time. It feels a bit strange to block such contributions. Or do you only block contributions where the employer would be visible, so no advertising?
melloware commented 5 months ago
  1. Let me fix that!
  2. Yes that is perfectly acceptable it just means "your employer does not own or have any rights to this work its being contributed by you for use in the community!".
melloware commented 5 months ago

OK updated to MPL that was a cut and past Contributing.MD from another project.

melloware commented 5 months ago

@lukas-mertens still interested in doing this?

lukas-mertens commented 5 months ago

@melloware I am. It will take a bit of time though. Probably during the next 2-3 weeks. If you have time right now, feel free to go ahead of course.

melloware commented 5 months ago

Nope i was just checking to make sure you were still interested. Leaving it assigned to you.