Fix follow property and the ScrollFollow component. (issue #14)

melloware / react-logviewer

React Lazy LogViewer

https://melloware.github.io/react-logviewer/

Mozilla Public License 2.0

45 stars 10 forks source link

Closed ClemensElflein closed 2 months ago

ClemensElflein commented 2 months ago

Fix #14.

Changes are the following:

Added onScroll callback to LazyLog component, this was completely missing. Therefore the ScrollFollow component could not track user's scrolling.
In the LazyLog component, the scroll position was not updated when follow property was true. I added the code to update the scroll position (only, if search is not in use).
The ScrollFollow component always overwrote the follow state with the initial value, also the logic never re-enabled scrolling.

melloware commented 2 months ago

Excellent I will review tomorrow and then create a 5.0.7 release. This looks great thanks!!