search

meln5674 / grafana-mongodb-community-plugin

Open Source Grafana Plugin for querying MongoDB
GNU Affero General Public License v3.0
137 stars 18 forks source link

bug/add-authentication-mongo-4.22.2 #1

Closed nstankov-bg closed 2 years ago

nstankov-bg commented 2 years ago

Hey!

Thanks for the awesome effort thus far! With this PR, I am adding the more secure SetAuth option, and fixing a small bug on line 229.

After the same is applied, the plugin no longer complains for authentication via SCRAM-SHA-256 or SCRAM-SHA-1

meln5674 commented 2 years ago

Thanks for the contribution! Looks like this slipped by because I used the username as the password in the integration tests, using something different reproduces the bug, and it works again with this applied.

nstankov-bg commented 2 years ago

Happy to help! I am VERY excited for this project.

I was fascinated by how easy and human it was to setup and build, compared to the original upstream.

Kudos for the work, @meln5674 .

I will attempt to poke more at it, as it is indeed an item of interest for dashboarding.