search

melo936 / ChromiumHardening

GNU General Public License v3.0
105 stars 12 forks source link

[Bug] Flag breaking Twitch.tv when logged in #5

Closed zealest closed 3 years ago

zealest commented 3 years ago

I don't know which flag breaks twitch (I followed your flags list on Chromium 94.0.4606.54) It happens only when you're logged in tho Capture

zealest commented 3 years ago

nevermind I restarted my computer and it works lol

zealest commented 3 years ago

ok nevermind again LMFAO it worked one time then I F5 the window and same error page

melo936 commented 3 years ago

I just signed up on Twitch to test it and nothing had happend yet. Unfortunately, I don't have any solution for it.

Could you update your Chromium build to 94.0.4606.61?

These flags were only added in our list:

#brave-debounce
#https-only-mode-setting
#in-product-help-snooze
#partitioned-cookies
#sharing-desktop-screenshots
#sharing-hub-desktop-omnibox
#username-first-flow-fallback-crowdsourcing

So, could you set #https-only-mode-setting and #partitioned-cookies to default/disabled?

Edit: Tested on Brave 1.32.20 Chromium: 94.0.4606.54 (Official Build) nightly (64-bit) and 94.0.4606.61 (Official Build, ungoogled-chromium) and everything works fine with/without experimental flags.

Check your extensions or command line flags, make sure there is no RendererAppContainer.

zealest commented 3 years ago

Ok, so I updated to 94.0.4606.61 and set #https-only-mode-setting and #partitioned-cookies to default and the problem persisted. I don't use any command line flags, only your chrome://flags list. I think I will just stick on stock Chromium and only use the Performance flags Thanks for your hard work!

zealest commented 3 years ago

Well it's quite weird because the problem persists even with "only" the performance flags and it never happened to me before (I used to follow your entire flags list) Also, I encoutered this problem only on Twitch so far.

melo936 commented 3 years ago

@Zealest The issue is caused by #enable-webassembly-lazy-compilation. Set the flag to Default.

Let me know if it is also fixed for you

kurtextrem commented 3 years ago

By the way, no issues in latest Chrome Dev.

melo936 commented 3 years ago

@kurtextrem

We disable WebAssembly in our command line flags, which makes this flag placebo, but I kept it, due to most people, who follow the guide (want improved performance), don't use command-line flags.

melo936 commented 3 years ago

https://github.com/brave/brave-browser/issues/18562 This bug will be fixed in Chromium 96+, so let's keep a little reminder here.