search

melonDS-emu / melonDS

DS emulator, sorta
https://melonds.kuribo64.net
GNU General Public License v3.0
2.98k stars 493 forks source link

Implement tile size scaling for the compute renderer #2065

Open FireNX70 opened 2 weeks ago

FireNX70 commented 2 weeks ago

Based on @RSDuck's comments in https://github.com/melonDS-emu/melonDS/issues/2047.

Right now it scales starting at 4.5x (effectively 5x). Based on some more recent testing, it looks like it should start scaling at 3.25x (effectively 4x). See this gist for more information. It also contains notes on the rationale behind the values for ClearCoarseBinMaskLocalSize.

The value used for CoarseTileCountY when using 32x32 tiles was chosen to match the base resolution's vertical resolution of 192 (6 32x32 tiles vertically per coarse tile means coarse tiles end up being 256x192).

FireNX70 commented 2 weeks ago

As far as I can tell, the absurd line count is github going insane over the changes to the shaders.

CasualPokePlayer commented 2 weeks ago

It seems more that the files' line endings got converted from LF to CRLF for some reason (text editor/IDE goof?)

FireNX70 commented 2 weeks ago

You're right, looks like VSCodium got me. Should be fairly easy to fix.

FireNX70 commented 2 weeks ago

Ok, looks like it's fixed but I'm not sure the line endings for the template I added to Utils.h aren't messed up. Thanks for the tip @CasualPokePlayer.