melonDS-emu / melonDS

DS emulator, sorta
https://melonds.kuribo64.net
GNU General Public License v3.0
3.16k stars 520 forks source link

Transparency issues in Sonic Rush #2126

Open emeraldroguefan opened 1 month ago

emeraldroguefan commented 1 month ago

All of Blaze's fire effects in Sonic Rush lack the proper transparency. I tried toggling every setting I could find to see if it was fixable, it does not look like there is anything on the user's end that can be done

If specs are needed:

Windows 11 7950X3D RTX 4080 64GB

What it currently looks like on melonDS 01 melonDS

What it should look like (screenshot taken on DeSmuME) 02 DeSmuME

CasualPokePlayer commented 1 month ago

Does the software renderer have the same issue?

CalebPancake commented 1 month ago

This also happened in Sonic Rush Adventure.

emeraldroguefan commented 1 month ago

Does the software renderer have the same issue?

The software renderer does not have this issue, no. Only OpenGL on melonDS. Works properly upscaled on other tested emulators though (DraStic, DeSmuME)

CalebPancake commented 1 month ago

It shows up for me. Even on Open GL. Screenshot 2024-08-05 172342

Screenshot 2024-08-05 172425

CasualPokePlayer commented 1 month ago

Does the software renderer have the same issue?

The software renderer does not have this issue, no. Only OpenGL on melonDS. Works properly upscaled on other tested emulators though (DraStic, DeSmuME)

This would just be another "the OpenGL renderer is woefully inaccurate" issue, in the latest dev builds, does it also occur for the new OpenGL Compute renderer?

CalebPancake commented 1 month ago

Doop dap doop da doop da doop da doop da doop da doop dap do do dap dop

emeraldroguefan commented 1 month ago

Does the software renderer have the same issue?

The software renderer does not have this issue, no. Only OpenGL on melonDS. Works properly upscaled on other tested emulators though (DraStic, DeSmuME)

This would just be another "the OpenGL renderer is woefully inaccurate" issue, in the latest dev builds, does it also occur for the new OpenGL Compute renderer?

Where do I find the dev builds?

CasualPokePlayer commented 1 month ago

https://github.com/melonDS-emu/melonDS/actions/runs/10240991703 for the current latest dev build on Windows as of typing this (scroll down to "artifacts")

emeraldroguefan commented 1 month ago

https://github.com/melonDS-emu/melonDS/actions/runs/10240991703 for the current latest dev build on Windows as of typing this (scroll down to "artifacts")

The problem is way worse now lol

Not only is the transparency issue still there, all of the models are flickering like crazy.

image

Sonic has seen better days image

emeraldroguefan commented 1 month ago

It's not captured well in this screenshot, but there are small holes appearing all over his body as he moves allowing you to see the background

emeraldroguefan commented 1 month ago

I swear I feel like I must have done something wrong

image

Edit: There was a major issue that was fixed at least. The black lines that appear on the overworld in HGSS do not appear anymore with the upscaler turned on. image

RSDuck commented 1 month ago

This is mixing up probably a bunch of different configurations and issues.

The transparency issue is probably related to OpenGL compositing which is shared between classic and compute shader OpenGL renderer.

all of the models are flickering like crazy

what do you mean by that?

I swear I feel like I must have done something wrong

The garbled rendering is another (known) issue with the compute shader renderer. Try changing the render resolution to workaround it.

CalebPancake commented 1 month ago

they should add vulkan support now

CalebPancake commented 1 month ago

please i swear to god

emeraldroguefan commented 1 month ago

what do you mean by that?

Sonic's model has a bunch of holes in it that were not visible on the old openGL renderer, regardless of render resolution

The garbled rendering is another (known) issue with the compute shader renderer. Try changing the render resolution to workaround it.

Lowering the resolution works, but I don't think that I would consider that practical fix. Never have I ever had to lower the resolution for a game in any emulator, this is usually a set it and forget it option.

Like, does it work? Yes, but at that point I wouldn't really feel comfortable recommending the emulator to anyone in its current state.

RSDuck commented 1 month ago

Sonic's model has a bunch of holes in it that were not visible on the old openGL renderer, regardless of render resolution

Are they also there at 1x (and not there with the software renderer)? If yes it is a bug which can probably be fixed. Otherwise I'm not chasing those polygon alignment issues, because you just can't win. DS games were never meant to be rendered at a different resolution than 256x192. More often the approach of the compute shader renderer of replicating the software renderer only at a higher resolution works, but well not always.

Lowering the resolution works, but I don't think that I would consider that practical fix.

That is a exactly what workaround means. What you downloaded is a development version, so things not completely working are to be expected.

emeraldroguefan commented 1 month ago

Are they also there at 1x (and not there with the software renderer)?

I can't tell if they are or aren't there with the software renderer, but it doesn't look like it? I don't know if this gives you any insight either, but it didn't happen with the old openGL renderer either

Software image

OpenGL (Classic) image

OpenGL (Compute shader) - it's really hard for me to get a screenshot of it since it's happening sporadically all over his body image

image

RSDuck commented 1 month ago

I'm specifically talking about 1x resolution scaling.

emeraldroguefan commented 1 month ago

I'm specifically talking about 1x resolution scaling.

Doesn't look like it then image

emeraldroguefan commented 1 month ago

Nevermind, it is happening at 1x. Just hard to get a screenshot of, compared all 3 to be sure

RSDuck commented 1 month ago

Ok then it is probably also fixable for the higher resolutions. I'll look into it eventually.

emeraldroguefan commented 1 month ago

https://github.com/user-attachments/assets/e74979a6-491d-4e21-9684-a00ce2f7a496

It should be visible on this video, look at Sonic's face

Jaklyy commented 1 month ago

had to download the video to view it (for some reason) looks like it could be a bug with aa maybe?