search

melonDS-emu / melonDS

DS emulator, sorta
https://melonds.kuribo64.net
GNU General Public License v3.0
3.33k stars 544 forks source link

Graphics problem with OpenGL (compute shader) #2206

Open walikor opened 1 week ago

walikor commented 1 week ago

Hi, if the internal resolution is 7X or higher I have this graphic problem, using 6X or less I have no problems, version 1.0 RC Immagine 2024-11-21 192450 Immagine 2024-11-21 192504

AndreCelso commented 1 week ago

i have the same artifacts (graphical glitches) on Inazuma Eleven 3 Sekai he no Chosen The Ogre using OpenGL (Compute Shaders) with internal resolution at 6x

user18081972 commented 1 week ago

This issue is basically a duplicate of https://github.com/melonDS-emu/melonDS/issues/2047

there is a pullrequest that fixes this problem in about 99% of cases https://github.com/melonDS-emu/melonDS/pull/2065 but it hasn't been merged into 1.0

extherian commented 1 week ago

Nor will it be, it seems to have been forgotten about.

user18081972 commented 6 days ago

Oh don't be dramatic. I am really very happy that RSDuck made the compute shader renderer for PC atall, because it fixes so many OpenGL graphical bugs! And for FireNX70 to make a pretty good fix for the problem we seem to be experiencing.

Also for context, this issue only seems to occur on Nvidia GPUs, because of some limit that Nvidia has set, and i'm sure if that was an easy fix, RSDuck would have been glad to make it. Also, as far as I could tell, RSDuck didn't seem to have an Nvidia GPU, so that would obviously further complicate things for him in fixing this.

Also, no one has tested FireNX70's pull request for regressions properly, and merging it without doing so could cause issues for others, so that might be a reason that it hasn't been merged, among maybe other reasons I'm not aware of. I'll try to test the PR on an AMD and Intel Arc GPU. I just so happen to be borrowing a Macbook tomorrow for 1 day, so i'll try to test it there aswell. It might be a while until I can borrow an Intel Arc GPU again.

Anyway, I compiled MelonDS 1.0RC with the pull request by FireNX70 merged into it. So anyone reading this could use this in the mean time if they want: melonDS 1.0RC+NvidiaComputeShaderWorkaround.zip It fixes the issue in 99% of cases IME.

If you don't trust files uploaded by a stranger (you shouldnt) then you can compile it yourself by forking this repo, comparing the changes of your repo-master to pullrequest 2065, and then building that using the build instructions.