melonDS-emu / melonDS

DS emulator, sorta
https://melonds.kuribo64.net
GNU General Public License v3.0
3.13k stars 511 forks source link

Native Npcap support #483

Open ghost opened 5 years ago

ghost commented 5 years ago

Currently you have to install npcap in winpcap compatible mode for melonDS infrastructre mode to work. I think moving to npcap native mode would be better because its more updated than Winpcap is. and it works better on both Windows 7 and 10.

Arisotura commented 5 years ago

good point

SatoMew commented 5 years ago

WinPcap has officially ceased development so it definitely should not be recommended anymore. Version 4.1.3 from 2013 was the last release and its installer is vulnerable to this exploit.

Arisotura commented 5 years ago

so I guess switching to npcap would be a wise thing to do

SatoMew commented 4 years ago

I guess this could be changed to not mention WinPcap:

https://github.com/Arisotura/melonDS/blob/eb6fe823f8196373906916b47fbeecf5d7a63e8a/src/libui_sdl/DlgWifiSettings.cpp#L34

The remaining usage is in comments.

ghost commented 4 years ago

good thing npcap could be used in win7 in addition to win10 lol.

Arisotura commented 4 years ago

might as well use npcap in, well, npcap mode, but we need to retain compatibility with Linux/etc