search

melonedo / zig-tls12

HTTP client capable of TLS 1.2.
MIT License
27 stars 5 forks source link

Update to zig 0.12.0-dev.3653+e45bdc6bd #7

Closed Cloudef closed 6 months ago

Cloudef commented 6 months ago

This simply uses the .raw fields of Uri.Component, might not be correct in all cases but should be equal to current implementation

melonedo commented 6 months ago

Is this a workaround or just migrating zig's new changes? I would prefer copying zig's implementation for it is easy to maintain.

Cloudef commented 6 months ago

Simply migration. By copying do you mean https://github.com/ziglang/zig/blob/master/lib/std/http/Client.zig can be simply copied over?

melonedo commented 6 months ago

Of course it is needed to make a few modifications to import TlsClient instead of std.tls.Client. Also, thank you for updating it! I will merge it after I check it locally.

---Original--- From: "Jari @.> Date: Tue, Apr 16, 2024 13:40 PM To: @.>; Cc: @.**@.>; Subject: Re: [melonedo/zig-tls12] Update to zig 0.12.0-dev.3653+e45bdc6bd (PR#7)

Simply migration. By copying do you mean https://github.com/ziglang/zig/blob/master/lib/std/http/Client.zig can be simply copied over?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Cloudef commented 6 months ago

Okay, then let me do this properly and copy over the latest http client

Cloudef commented 6 months ago

Maybe I did it correctly. The upstream TLSClient seems to have some new errors that aren't in your implementation, so I removed those from the switch.

melonedo commented 6 months ago

Many thanks!