Lost items in Rails

[GoogleCodeExporter]

The website needs to show items that are lost.

1. A menu item "Lost Items"
2. A red status bar across the top of incoming items showing "n Items are 
reported as lost"
3. Update the specimen view if item is lost. Show this prominently.

Original issue reported on code.google.com by rockina...@gmail.com on 24 May 2011 at 5:54

[GoogleCodeExporter]

Changed to have Allen as the owner.

Original comment by rockina...@gmail.com on 24 May 2011 at 5:55

[GoogleCodeExporter]

Issue 114 has been merged into this issue.

Original comment by liu.al...@gmail.com on 24 May 2011 at 11:48

[GoogleCodeExporter]

Could you add documentation to /app/views/help/items.html.erb for using the 
Lost Items UI after you have implemented it?

I have the placeholder for the help section, but currently nothing is there.

Original comment by donovanh...@gmail.com on 25 May 2011 at 8:05

[GoogleCodeExporter]

I did a little bit of the index page before I noticed this issue.
Going back to routes/checklists now.

Original comment by stein.za...@gmail.com on 25 May 2011 at 6:57

[GoogleCodeExporter]

I fixed up the styling and fixed the add new item page.
I haven't implemented limiting adding lost items from only the users location.

also, you can add two different lost items that are actually the same item. 
Should we disable this behavior?

Original comment by liu.al...@gmail.com on 27 May 2011 at 5:41

• Changed state: Fixed

[GoogleCodeExporter]

Yes we should...you should be able to use validates_uniqueness_of for this (see 
the Identifiers model for an example) to make sure there are no duplicate 
item_ids.

Actually, I just fixed the above (was just the validation)

You should also limit the view (list of lost items should only be for items 
going to/from user's location, unless they are an admin where they see all).

This looks really good though!

Just limit privileges and it should be ready to ship

Original comment by donovanh...@gmail.com on 27 May 2011 at 8:36

• Changed state: Started

[GoogleCodeExporter]

Original comment by donovanh...@gmail.com on 27 May 2011 at 8:36

[GoogleCodeExporter]

Lost items should be all done.

Original comment by liu.al...@gmail.com on 27 May 2011 at 10:50

• Changed state: Fixed

[GoogleCodeExporter]

I also added a mark as lost link on the item information page.

Original comment by liu.al...@gmail.com on 27 May 2011 at 10:51

[GoogleCodeExporter]

I shouldn't be able to mark it as lost if the item is already lost (will cause 
an error and lead me to "/lost_items/new" which would be confusing).

Also, we should show that items are lost in the items information page 
(_item_information.html.erb)

Original comment by donovanh...@gmail.com on 27 May 2011 at 11:03

[GoogleCodeExporter]

See above

Original comment by donovanh...@gmail.com on 27 May 2011 at 11:03

[GoogleCodeExporter]

Okay. Where should the indication that its marked as lost be? Next to the item 
name?

Original comment by liu.al...@gmail.com on 27 May 2011 at 11:24

• Changed state: Started

[GoogleCodeExporter]

How about in the status section?

The statuses that show up there can basically be "Lost", "Waiting Pickup", "In 
Transit", and "Delivered"

Then we can also add the comment associated with lost items below it.

We could also stylize "Lost" in a way that stands out.

This might be more work, but I think it intuitively makes sense?  What do you 
think?

Original comment by donovanh...@gmail.com on 28 May 2011 at 12:27

[GoogleCodeExporter]

This sounds like a good idea. It shouldn't be too difficult either.

Original comment by liu.al...@gmail.com on 28 May 2011 at 12:32

[GoogleCodeExporter]

Verify?

Original comment by liu.al...@gmail.com on 28 May 2011 at 1:34

• Changed state: Fixed

[GoogleCodeExporter]

A couple things:

While looking over the documentation, I realized something.  Lost items should 
be editable (or at least the comment is).  This way, when it is resolved, you 
can edit the lost item's comment to say what happened to it.  Otherwise, it 
seems like resolving items has no point.

And to that point, shouldn't we also be toggling the ability to hide lost items 
that are resolved?

Original comment by donovanh...@gmail.com on 28 May 2011 at 1:43

• Changed state: Started

[GoogleCodeExporter]

Yes, thats true. Are we still adding a 'hidden' field for lost items?

Should the lost item's comment be editable? Or should you only be able to add 
additional comments so as to keep an immutable record? 

Original comment by liu.al...@gmail.com on 28 May 2011 at 1:54

[GoogleCodeExporter]

No I think we can just toggle based on "resolved" (no hidden needed)

We don't have the database in place to allow multiple comments for a lost item, 
so I don't know...if you want to set up the database to handle it, then that's 
fine.

Original comment by donovanh...@gmail.com on 28 May 2011 at 2:17

[GoogleCodeExporter]

I think this page mostly just needs a way to view only unresolved reports.

The add new form also breaks if you submit it without filling anything out.

Original comment by stein.za...@gmail.com on 30 May 2011 at 8:20

[GoogleCodeExporter]

Ok. Only unresolved lost-items will be shown then. This also means it is 
impossible to mark an item as lost, resolve it, but then decide to mark it as 
lost again.

I'll fix the empty form submission bug. Thanks for finding that Zach.

Original comment by liu.al...@gmail.com on 30 May 2011 at 8:32

[GoogleCodeExporter]

Alternatively you could add a "Show Resolved" button similar to the "Show 
Hidden" buttons on the locations page for instance so that the user could 
toggle resolved items on/off.

Original comment by stein.za...@gmail.com on 30 May 2011 at 9:13

[GoogleCodeExporter]

Zach, if I use the same session variable, session[:show_hidden_items], will 
that conflict with the locations page? Should I use something different such as 
:show_resolved_lost_items?

Original comment by liu.al...@gmail.com on 30 May 2011 at 9:49

[GoogleCodeExporter]

If you use the same session variable as is used elsewhere, yes, they will 
conflict, so I'd say :show_resolved_lost_items sounds good

Original comment by stein.za...@gmail.com on 30 May 2011 at 9:58

[GoogleCodeExporter]

I'm trying to getting this hide resolved lost items to work, but whenever I 
click on:
http://localhost:3000/lost_items/toggle_resolved, it tries to find a lost item 
with id of toggle_resolved, instead of performing the 'toggle_resolved' action 
that i've written and placed in the lost_items controller...I don't understand 
why what I've set up doesn't work, but what you have does. Is there something 
i'm missing?

Original comment by liu.al...@gmail.com on 30 May 2011 at 10:15

[GoogleCodeExporter]

Hmmm..nevermind. It was a routing error.

Original comment by liu.al...@gmail.com on 30 May 2011 at 10:39

[GoogleCodeExporter]

Please verify:

1) You can edit comments.
2) You can toggle showing resolved.
3) Entering invalid or blank identifiers doesn't make it crash.

Original comment by liu.al...@gmail.com on 30 May 2011 at 11:22

• Changed state: Fixed

[GoogleCodeExporter]

Looks good except comments should not be "required" when editing (only mark as 
required if there is a validation that takes place that will cause an error if 
they didn't put it).  Other than that it looks great!

Original comment by donovanh...@gmail.com on 30 May 2011 at 5:27

• Changed state: Started

[GoogleCodeExporter]

I'll fix that.

Original comment by liu.al...@gmail.com on 30 May 2011 at 7:34

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by liu.al...@gmail.com on 31 May 2011 at 4:20

• Changed state: Verified