Closed GoogleCodeExporter closed 8 years ago
Not really sure who to assign these to so just giving them all to you Zach.
Feel free to reassign.
Original comment by phil...@gmail.com
on 28 May 2011 at 3:32
Original comment by stein.za...@gmail.com
on 28 May 2011 at 6:05
I'm working on this form now. It's proving itself to be tough...
I'll get it ready by 1.0 definitely.
Original comment by donovanh...@gmail.com
on 28 May 2011 at 6:52
You can now remove items that you accidentally added in the new-item-form
(before items are created).
You can also remove items that you have already added in the item-information
form (this will redirect you to the removed item page, if you want it to go
somewhere else, just tell me).
Original comment by donovanh...@gmail.com
on 28 May 2011 at 8:49
just tried remove from the container's show page... redirected to the included
item's show page but didn't actually remove the item from the container.
Are you working on the add item page? Links to an empty page right now.
Original comment by stein.za...@gmail.com
on 28 May 2011 at 10:06
I am working on the Add to Bag page...it should hopefully be ready by the end
of the weekend. I'm having some problems with error cases and adding "New
Items" to the Bag.
What do you mean the item was not actually removed? Could I get some repro
steps (it works for me)...did you click "back" and not refresh the page? That
is a case I can see where it doesn't look like it worked, but if you refresh it
will show correctly.
Also, back to the design question...should I be redirecting to the contained
item page or the container page?
Original comment by donovanh...@gmail.com
on 28 May 2011 at 10:55
I went back to the items page and clicked on the bag and the item was
still there. Maybe it has been fixed or I was mistaken though, I will
try to reproduce later and let you know if it still doesn't work for
me.
I would redirect to whatever page they came from (redirect_to :back).
I think this is always the container's page?
On Sat, May 28, 2011 at 3:56 PM,
<lab-specimen-transport-system@googlecode.com> wrote:
Original comment by z.b.st...@gmail.com
on 28 May 2011 at 11:40
I have a little more logic in that action (I'm also handling adding items to
the bag from here), but I'm now redirecting to the Container's page (so you can
actually see the changes).
Also, Add to Bag is working. Could you verify all these?
And tell me if you get a working repro on the problem you were having before.
Original comment by donovanh...@gmail.com
on 29 May 2011 at 12:16
Okay, a few comments:
Did we decide to have a delete button? I think it's sometimes okay to delete
items, but I'm not really sure when, so unless you've thought it through I
would just get rid of the button - your call.
Adding items seems to work and I like the UI.
If I create a bag, add a new item to it from the bag's show screen, return to
that bag's show screen and hit remove two things: I get redirected to the
specimen's show screen - I think I should stay on the bag screen (for one, you
can actually see the item get removed that way), and two, the item still shows
up as inside the bag on the bag's show screen. If this works for you, I will
try to repro again on staging.
It's really coming together overall, good job :)
Original comment by stein.za...@gmail.com
on 30 May 2011 at 8:19
You should not be able to delete items if they have already been picked up
(basically you can only delete if the latest check_in is not an
initial_checkin). I have checked on staging and this does not work in all
cases. Could you look into this (I quickly tried sorting the checkins be their
created_at value, but it didn't work right away)?
Both of these comments should be implemented. If you could try again on
staging or something that'd be great.
Original comment by donovanh...@gmail.com
on 30 May 2011 at 3:47
Alright, I looked into being able to delete items when shouldn't be able to and
I believe I fixed it. Could you check again (we were taking the first checkin
and not the last)?
Original comment by donovanh...@gmail.com
on 30 May 2011 at 5:35
Were you using sort by created_at desc, then taking the first? That is what i'm
doing to take the most recent check in. Is this wrong? It seems to be working
for displaying the status.
Original comment by liu.al...@gmail.com
on 30 May 2011 at 7:34
I'm not sure what the deal with deleting is. Can you just check the check_in
count maybe (1 -> created and that's it -> okay to delete (document))?
Removing from bag still doesn't work for me.
Original comment by stein.za...@gmail.com
on 31 May 2011 at 10:43
This issue was closed by revision 021333227c22.
Original comment by donovanh...@gmail.com
on 1 Jun 2011 at 11:30
Could you check that this works now?
Original comment by donovanh...@gmail.com
on 1 Jun 2011 at 11:32
On staging, I removed an item from the bag with identifier "superbag" but when
I hit "Add to Bag" the item I just removed doesn't show up. Is it not a valid
item to add back? Seems like it should be. Other than that filtering,
everything looks good.
Original comment by stein.za...@gmail.com
on 2 Jun 2011 at 2:17
It's possible it shouldn't be allowed to be added back. I added filters that
means you're only allowed to add an item if it is going to the same
destination, has the same source, and has the same inherited attributes
(transport conditions). It's possible that item you removed was there before
the filtering and now it can't be added back.
With this new filter there will be few existing items that you can actually add
to the bag, but I think this is more realistic.
Original comment by donovanh...@gmail.com
on 2 Jun 2011 at 2:30
Ah, I didn't check the destination. Looks good.
Original comment by stein.za...@gmail.com
on 2 Jun 2011 at 2:33
Original issue reported on code.google.com by
phil...@gmail.com
on 26 May 2011 at 11:17