melonhead901 / lab-specimen-transport-system

Automatically exported from code.google.com/p/lab-specimen-transport-system
0 stars 0 forks source link

Merge Both RecurrenceRules Models into One Generic Model #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The two recurrence_rules models could be combined into a single polymorphic 
model as described here:

http://guides.rubyonrails.org/v2.3.8/association_basics.html#polymorphic-associa
tions

This will make applying the recurrence rules (generating route and checklist 
instances) more generic and therefore less repetitive to code. It also suggests 
a Task abstraction, where Checklists and Routes are both instances of tasks. 
Expanding on this idea would allow for a more configurable "A Courier's Day" 
page, where Checklist Items and Stops could be more easily mixed.

The controllers, tests, views, routes, and helpers will need to be "combined" 
as well (delete one, fix field names in other).

Original issue reported on code.google.com by stein.za...@gmail.com on 25 Apr 2011 at 3:53

GoogleCodeExporter commented 8 years ago

Original comment by stein.za...@gmail.com on 25 Apr 2011 at 6:32

GoogleCodeExporter commented 8 years ago

Original comment by stein.za...@gmail.com on 10 May 2011 at 6:16

GoogleCodeExporter commented 8 years ago
Closing this until we decide how to deal with checklists.
I think Checklists and Stops should be abstracted into Tasks, which should be 
encapsulated in a Workflow or something similar.
I will clean this up next week.

Original comment by stein.za...@gmail.com on 21 May 2011 at 3:28

GoogleCodeExporter commented 8 years ago
Alternately, we just delete the checklist abstraction, and it's essentially a 
route, except filled with checklist item instances instead of stop instances. 
Possible even further, we just combine this all into a route.

Original comment by melonhea...@gmail.com on 21 May 2011 at 9:26