melonJS 1.0.1

[parasyte]

@obiot @agmcleod I have created a new 1.0.x branch and tracker milestone, scheduled for release at the end of the month. We can use this to begin testing the workflow described in #471.

So far I have only a super simple patch in the 1.0.x branch that was cherry-picked from 1.1.0-dev. Usually we would cherry-pick from master, but the only difference now is that our dev branch is not named master. ;)

At the end of the month, we can tag the 1.0.x branch with 1.0.1 for release. Then continue applying bug fixes on top of it, and tagging as we make new minor releases. How does it sound?

[agmcleod]

I'm guesing you mean that our dev branch is now named master? :) Just double checking where i should be committing!

[parasyte]

Noooooo! I haven't renamed or merged the dev branch. I was commenting that when following the workflow in #471, the dev branch would be named master. But right now it is still named 1.1.0-dev. So continue committing there for now. :)

We'll call it a transition period? heheh.

[agmcleod]

kk, so what is master? :)

[parasyte]

Currently it is the same as 1.0.0, but with a recent commit that adds another badge to the README. shrug :smiley:

[obiot]

seems that 1.0.1 is done, very last chance to add anything else in, if you feel the need to :P

after these quiets last couple of weeks and this release, back on work guys !

[parasyte]

Nice!

[obiot]

wow, lot's of fix and discussion yesterday :P:P:P

I have not went through all of them, but shall we still wait a little for 1.0.1 or is it ready for release (I was planning to do it once back from my business trip today)

any changes as well to add to the Changelog ?

[aaschmitz]

@obiot Add the fix for particle emitter bounds and the input key bindings ;)

[parasyte]

@obiot 1.0.1 is not ready. See #499: Fixed on master, but some of the changes have not been back-ported to 1.0.x. Ping @agmcleod :wink:

[obiot]

ahahah, yes then, 2xPing @agmcleod :P:P:P

[agmcleod]

Quit the pingin you two! I did them on the 1.0.x branch since i believe this qualified as a bug, and then merged that into master.

https://github.com/melonjs/melonJS/blob/1.0.x/src/entity/entity.js#L172 https://github.com/melonjs/melonJS/blob/1.0.x/src/loader/loader.js#L552

[parasyte]

https://github.com/melonjs/melonJS/blob/1.0.x/src/loader/loader.js#L552

This one still needs to be fixed.

parasyte@HandBanana:~/projects/melonJS (1.0.x)$ grunt lint
Running "jshint:beforeConcat" (jshint) task
Linting src/loader/loader.js ...ERROR
[L552:C21] W108: Strings must use doublequote.
            elt = '' + elt;
[L574:C21] W108: Strings must use doublequote.
            elt = '' + elt;
[L597:C21] W108: Strings must use doublequote.
            elt = '' + elt;
[L620:C21] W108: Strings must use doublequote.
            elt = '' + elt;

Warning: Task "jshint:beforeConcat" failed. Use --force to continue.

Aborted due to warnings.

Like I said, only fixed on master. ;) https://github.com/melonjs/melonJS/commit/235ba264b4fc51dbb9fc7f611b0f59f066d59bf0

[agmcleod]

I did notice that in the code, but i dont get errors when I build, and travis is passing. I'll still fix though, so you can stop nagging me ;)

[parasyte]

Ah, run npm install again to update the dev dependencies. You probably have an older jshint that doesn't read all of the new options.

[agmcleod]

Ah interesting. master loved to fail on that, hence why it's fixed there.

[obiot]

and I guess this time, we are good to go with 1.0.1 ? :P

[aaschmitz]

:+1:

[parasyte]

I added #508 to the 1.0.1 milestone yesterday. Do you want to take a look at it before making the release official?

[obiot]

honestly I would rather keep for a later (1.0.2?) version or master branch, as I also never did use bowler (so I do need to play with it as well first to understand how it works) and I would like to finally get over with this 1.0.1 release and switch back to more funny things.

but if you have a script ready, please for sure go ahead :P

[parasyte]

I only have a shell script for it right now. So I'll move the milestone.

BTW, bower is very basic. It doesn't include any complex steps like "build source"... it just downloads the latest release (or specified version) and extracts the contents. That's why #508 is kind of complicated; we need to include the built js files in the tag, but not in any branch.

[obiot]

finally : done !

https://github.com/melonjs/melonJS/releases/tag/1.0.1

[parasyte]

Alright!

[agmcleod]

nice :D

[obiot]

lol, just missed the newer version of howler by a couple of hours ;P

[obiot]

I just finally properly used the release page : https://github.com/melonjs/melonJS/releases

that now contains all release note and build file :P

[ellisonleao]

Nice! :+1:

[parasyte]

@obiot in response to Howler, I think it's a good thing that we missed it. We don't want to update dependencies right before a release anyway. :wink: These things need to bake for a while before they are proven stable.

The Howler update is perfect for 1.1.0 right now, but I don't recommend updating it in 1.0.x.

[parasyte]

Also, we can integrate the github release API with #508 ... the grunt-release task is a good starting point.