search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

cl-defmethod didn't exist before Emacs 25.1 #17

Closed DamienCassou closed 6 years ago

DamienCassou commented 6 years ago

I think there is a problem with package-build which breaks Cask and then EVM:

In toplevel form:
package-build-badges.el:36:1:Error: Symbol's function definition is void: cl-defmethod
Compiling /home/travis/.emacs.d/.cask/24.3/bootstrap/package-build-20180324.2042/package-build-pkg.el...
Compiling /home/travis/.emacs.d/.cask/24.3/bootstrap/package-build-20180324.2042/package-build.el...
In toplevel form:
package-build.el:48:1:Error: Symbol's function definition is void: cl-defmethod
Compiling /home/travis/.emacs.d/.cask/24.3/bootstrap/package-build-20180324.2042/package-recipe-mode.el...
In toplevel form:
package-recipe-mode.el:36:1:Error: Symbol's function definition is void: cl-defmethod
Compiling /home/travis/.emacs.d/.cask/24.3/bootstrap/package-build-20180324.2042/package-recipe.el...
In toplevel form:
package-recipe.el:67:1:Warning: `(rcp package-recipe)' is a malformed function
package-recipe.el:67:15:Warning: reference to free variable
    `package-recipe--working-tree'
package-recipe.el:69:28:Warning: reference to free variable `rcp'
package-recipe.el:71:1:Warning: `(rcp package-recipe)' is a malformed function
package-recipe.el:71:15:Warning: reference to free variable
    `package-recipe--upstream-url'
In end of data:
package-recipe.el:109:1:Warning: the function `cl-defmethod' is not known to
    be defined.
Wrote /home/travis/.emacs.d/.cask/24.3/bootstrap/package-build-20180324.2042/package-recipe.elc
Done (Total of 1 file compiled, 3 failed, 2 skipped)
Symbol's value as variable is void: package-recipe--working-tree
Cask could not be bootstrapped. Try again later, or report an issue at https://github.com/cask/cask/issues
tarsius commented 6 years ago

I can probably fix that by using the obsolete defmethod instead. But you should also check what is going on here:

$ export EVM_EMACS=emacs-25.1-travis

...
Wrote /home/travis/.emacs.d/.cask/24.3/bootstrap/archives/gnu/archive-contents
TheBB commented 6 years ago

Thanks for fixing this, was driving me up the wall lately.

But you should also check what is going on here:

I think that's just because cask itself runs in an Emacs 24.3 environment.

DamienCassou commented 6 years ago

Thank you @tarsius. I agree with @TheBB, this is not a bug :-).

tarsius commented 6 years ago

We had to wait a few hours for the Melpa package-build package to become available. Turns out there's another issue and we have to wait another few hours. But this time around I locally tested with the Emacs version used by Melpa, so changes are good these fixes are enough.