search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

Divide into more sections, and assorted cleanup #3

Closed tarsius closed 7 years ago

tarsius commented 7 years ago

I actually wrote most of this around the time when package-build.el got its own repository, but did not get around to finishing it.

You might want to drop the last commit as it adds a dependency on Emacs 24.5.

The two commits before that are the most important to me. See in particular the commit message of 3b8834e4521653add4842ffadd93126058ce0742. I did that because I was looking into melpa/melpa#2955 and found it hard to determine what parts of the code were relevant to that.

The remaining commits implement assorted cleanup, which also helped me understand the existing code.

purcell commented 7 years ago

This is great, thanks! I'd prefer to skip the last commit for now, to retain compatibility with 24.3. I'll get to merging it in a few days, unless you feel like tackling it: I'll add you as a committer here.

Ultimately I'd like to add some hooks that get run when packages are built, so that we can have a separate "melpa.el" which generates the badge images etc, and also to maybe run tools like package-lint.el. There's a bunch of MELPA stuff mixed in here which doesn't belong with the other code. I haven't thought much about what those hooks would look like: I think they'd need to be passed package info, including where those packages have been generated.

purcell commented 7 years ago

Ah, you already have access. So yep, happy for you to go ahead and merge, and ideally also update the merged version in the main MELPA tree correspondingly.

tarsius commented 7 years ago

I'll let this rest a bit, but it shouldn't make me another 1/2 year ;-)

purcell commented 7 years ago

Thanks for tackling this!