search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

Fix erroneous comment. #47

Closed matta closed 3 years ago

matta commented 3 years ago

The code in question is actually taken from Emacs 28.

tarsius commented 3 years ago

Are you sure? I.e. please mention the relevant commit so that it becomes easier to verify this.

matta commented 3 years ago

The Emacs commit is 963a9ffd66cb29f0370e9a4b854dddda242c54a6, which is present only on the master branch (Emacs 28.*).

Here is the commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=963a9ffd66cb29f0370e9a4b854dddda242c54a6

See the current state of the code for each branch:

http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/lisp-mnt.el?h=emacs-27#n479 http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/lisp-mnt.el?h=master#n481

See the history of lisp-mnt.el for each branch:

http://git.savannah.gnu.org/cgit/emacs.git/log/lisp/emacs-lisp/lisp-mnt.el?h=emacs-27 http://git.savannah.gnu.org/cgit/emacs.git/log/lisp/emacs-lisp/lisp-mnt.el?h=master

Or, if you like github better :-)

https://github.com/emacs-mirror/emacs/commits/master/lisp/emacs-lisp/lisp-mnt.el https://github.com/emacs-mirror/emacs/commits/emacs-27/lisp/emacs-lisp/lisp-mnt.el

tarsius commented 3 years ago

Apparently the "Follows" information in commit buffers is less useful than I thought. I.e. magit-get-current-tag, i.e. git describe ....

The reliable way to confirm is git merge-base --is-ancestor 963a9ffd66cb29f0370e9a4b854dddda242c54a6 emacs-27.1 && echo true.

tarsius commented 3 years ago

Please amend to the commit and edit the commit message to mention this commit.

matta commented 3 years ago

I couldn't figure out how to amend/squash/force this pull request. I created the commit via the github web interface, which happened to fork and place the commit in a patch-1 branch under github.com/gmatta/package-build. I did amend that commit, force push it, but the pull request did not update.

So, I sent a new pull request: #48