search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

Rename and refactor package-build-expand-files-spec #60

Closed tarsius closed 2 years ago

tarsius commented 2 years ago

This also includes the commits from #59; please see that first.

Previously the code and documentation in some talked about "file specs" in some places and "files spec" in other. I changed it to "files spec"; one spec that specifies multiple files. Does that more or less make sense to a native speaker too?

I have also refactored the function, spinning out a helper function. This makes the code a bit more readable and avoids some repeated work.

I have compared the output of the old and the new implementation for all packages on Melpa. There are no differences.

tarsius commented 2 years ago

I have restored the old package-build-expand-file-specs for backward compatibility (i.e., cask). The other removed functions aren't used in any package on the emacsmirror (a superset of melpa), though they are mentioned in comments of keg, which copy-pastes some code from package-build.el.