search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

fix(package-build.el): Don't check for file-executable-p #73

Closed jcs090218 closed 1 year ago

jcs090218 commented 1 year ago

Having (file-executable-p "tar") wouldn't work, and it will always return nil.

We have two solutions,

  1. Remove file-executable-p check
  2. Use (executable-find "tar") while assigning value to package-build-tar-executable
(defcustom package-build-tar-executable (executable-find "tar")
  ...
jcs090218 commented 1 year ago

cc @tarsius

tarsius commented 1 year ago

Thanks!

Please use commit messages that are more in line with other commit messages in this repository. See the commit message I used.

Also please consider giving the maintainers permission to push to your feature branches. That way we can make small changes (such as improving the commit message) and then push that to your branch. That way, when the end result is merged, Github can automatically close the pull-request and the pull-request does not forever remain "unmerged".

jcs090218 commented 1 year ago

Please use commit messages that are more in line with other commit messages in this repository. See the commit message I used.

Yeah, that's my fault. I usually open up issue/PR for discussion first, but that's not an excuse to not do that. And again, thank you so much! 👍

Also please consider giving the maintainers permission to push to your feature branches. That way we can make small changes (such as improving the commit message) and then push that to your branch. That way, when the end result is merged, Github can automatically close the pull-request and the pull-request does not forever remain "unmerged".

I have tried to do that but failed. I am not able to find the allow merge commits button. Is it something with the repository settings?

tarsius commented 1 year ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork documents how to do it after creating the pr.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork documents how to do it while creating the pr.

I could not find instructions on how to configure the default, but I believe that whenever you change the value while creating a pr, that also becomes the new initial value when you create other prs later on.