melquibrito / source-code-editor-tinymce-plugin

Tinymce advanced custom plugin for editing source code.
MIT License
15 stars 9 forks source link

Does not update correct editor when there are multiple editors on the page. #1

Open sanelson2000 opened 3 years ago

sanelson2000 commented 3 years ago

I have a page with 2 tinymce editors on it. And just installed your code editor plugin (which is very nice, BTW). If I try to use the code editor plugin on the first editor, when I click Save, it overwrites the contents of the second editor with the value instead of updating the first. It appears that tinymce.activeEditor is not always returning the editor that the plugin was called from. I hacked around it by passing the editor variable to displayToxEditorModal and setting the id of the editor as a data attribute on the modal, which I then read back in saveContent()... But I'm sure there's probably a cleaner way to do it.

function displayToxEditorModal(e, display = true) {
  let el = document.getElementById('tox-codeeditor-wrap');
  if (display) {
    el.dataset.editor = e.id;
    el.style.display = "flex";
    el.focus();
    document.body.classList.add('tox-codeeditor__disable-scroll');
  } else {
    e = e || tinymce.get(el.dataset.editor);
    el.style.display = "none";
    document.body.classList.remove('tox-codeeditor__disable-scroll');
    e.focus();
  }
}

function saveContent() {
  let el = document.getElementById('tox-codeeditor-wrap');
  let e = tinymce.get(el.dataset.editor);
  e.focus();
  e.undoManager.transact(function() {
    e.setContent(aceEditor.getValue())
  });
  e.selection.setCursorLocation();
  e.nodeChanged();
  displayToxEditorModal(e,false);
}
prathamVaidya commented 7 months ago

@sanelson2000 I don't think this plugin is maintained any further. For anyone landing here in future, Try supercode plugin that I created for tinyMCE editor. It fixes all these issues and offers more.

chrome-capture-2024-4-7 (1)