search

melt-umn / copper

An integrated context-aware scanner and parser generator
http://melt.cs.umn.edu/copper
GNU Lesser General Public License v3.0
18 stars 4 forks source link

Minimal change for building on Java 11 #45

Closed tedinski closed 5 years ago

tedinski commented 5 years ago

The old version of the surefire plugin has a bug that gives a null pointer exception on Java 11. Just updating the version fixes it.

Probably, some attention should be paid to updating versions of dependencies and plugins in general, but that can wait for another day.

schwerdf commented 5 years ago

I assume this does not break compatibility with earlier Java versions? Copper will nominally work on anything as far back as Java 6.

tedinski commented 5 years ago

Good question. I have not tested 6. It looks like the surefire plugin might be targeting minimum version java 7 now, but that might be for the even newer version (3.x series). (Version compatibility information is surprisingly hard to find?)

I was expecting Jenkins to test 8 for me when I pushed this pull request. I'm not sure why github isn't displaying a build indicator. (@krame505 do you know if Jenkins is acting up for Copper or something? I see a build in progress for the patch I made to Silver, but no indicator here.)

krame505 commented 5 years ago

Jenkins has been broken for a few months now, it seems to no longer be seeing push events. Not sure what happened. We've just been triggering builds manually for a while.

ericvanwyk commented 5 years ago

We do need Jenkins, picking up this discussion on the Jenkins issues: https://github.com/melt-umn/jenkins-lib/issues/16

schwerdf commented 5 years ago

Regarding Java versions, since Java 6 has been EOL'd, there is no longer any overwhelming need to support it, but if we do drop support, we need to update the version numbers in the Maven files and the user guide.

tedinski commented 5 years ago

Jenkins came through, so this is good for Java 8. Since the plugin advertises Java 7 compatibility for an even newer version, I think we can assume it works there.

Should we merge then?

schwerdf commented 5 years ago

I will take care of the version rejiggling.