search

meltano / hub

The single source of truth for all Meltano plugins, including all available Singer Taps and Targets: https://hub.meltano.com
https://hub.meltano.com
50 stars 68 forks source link

feat: Make License mandatory for plugins submitted to meltanohub #1302

Open rawwar opened 1 year ago

rawwar commented 1 year ago

reference discussion link: https://meltano.slack.com/archives/C024T93P0AJ/p1683318763082389

Reason: This can help from using sources which have restrictive licenses. Make better informed choices when choosing a plugin

pnadolny13 commented 1 year ago

@rawwar thanks for logging this! I also created https://github.com/meltano/hub/issues/1307 to document these standards and what to do with existing plugins that dont meet the standard.

edgarrmondragon commented 1 year ago

https://spdx.org/licenses/ is a good resource to get a list of valid license IDs

rawwar commented 1 year ago

Also, all the ones that are currently default.. if they don't have a license.. we should probably remove them as default. And also include a note about missing license.. if anyone's trying to download them.

I'm proposing that because, licenses are probably the first thing orgs look at when using them. So, I think its important we highlight that.

tayloramurphy commented 1 year ago

@pnadolny13 per @rawwar's comment, do you know which plugins are default that don't have a license? I would agree that the default variant should have a license, especially if there are multiple variants available.

pnadolny13 commented 1 year ago

@tayloramurphy it actually looks like a fair amount of them dont have a license including some on MeltanoLabs so I created https://github.com/MeltanoLabs/Meta/issues/46. I also would love to see https://github.com/meltano/sdk/issues/235 get implemented with a default, some users just simply forget about a license.

edgarrmondragon commented 1 year ago

@pnadolny13 see https://github.com/meltano/sdk/pull/1709

rawwar commented 1 year ago

Just wondering, is it ok to update meltanohub repo's Github actions' with a task to checkout the repo and check if the license file exists? and if not.. fail it?

pnadolny13 commented 1 year ago

@rawwar I think thats a great idea! It can be added as another CI workflow https://github.com/meltano/hub/tree/main/.github/workflows.