meltano / hub

The single source of truth for all Meltano plugins, including all available Singer Taps and Targets: https://hub.meltano.com
https://hub.meltano.com
50 stars 68 forks source link

Update OAuth instructions to use curl to get refresh token #1858

Closed thena-seer-sfg closed 1 month ago

thena-seer-sfg commented 1 month ago

Summary

The current instructions are incorrect. The code received in the redirect url is not a refresh token but a short-term authorization code, and the tap fails when it tries to use it as one. In order to get a refresh token, there is a code exchange step. The easiest way to do this is using curl, so I've added this step to the instructions.

This is based on Harvest's documentation: https://help.getharvest.com/api-v2/authentication-api/authentication/authentication/#oauth2-authorization-flow

I have also opened this PR in the source repo, where it seems these instructions were copied from: https://github.com/singer-io/tap-harvest-forecast/pull/28

Test plan

Follow the updated instructions when setting up the extractor in meltano. Verify meltano config tap-harvest-forecast test confirms the validity of the configuration.

netlify[bot] commented 1 month ago

Deploy Preview for meltano-hub ready!

Name Link
Latest commit a78eb75d2762ea9b6bf721fb3e10be631d3abf01
Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/66fadf98a0cf510008f8c608
Deploy Preview https://deploy-preview-1858--meltano-hub.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.