search

meltano / hub

The single source of truth for all Meltano plugins, including all available Singer Taps and Targets: https://hub.meltano.com
https://hub.meltano.com
50 stars 68 forks source link

Use tailwind.css #783

Closed cjohnhanson closed 2 years ago

cjohnhanson commented 2 years ago

tailwind will make styling much easier and enable quicker development and provides a lot of useful utility classes for easy responsive UI.

Gridsome has a plugin to make this easier.

rwfeather commented 2 years ago

Agree that tailwind will set us up a lot better for styling and layouts.

aaronsteers commented 2 years ago

@cjohnhanson - Thanks for logging. I think this makes sense to add sooner than later. To follow the principal of not having 'unused code paths', I recommend we add the tailwind library at the same time as implementing it in one or more locations, in order to improve layout or to improve rendering of our grid view results, for instance.

aaronsteers commented 2 years ago

@cjohnhanson and @rwfeather - Should we still do this one?:

And if so, should we combine 'adding saas support' with 'adding tailwind support' together as the same PR - or keep separate?

cjohnhanson commented 2 years ago

@aaronsteers I'll defer to @rwfeather for final 👍 /👎 but I think tailwind has enough support for theming that we probably don't need sass/scss. We would just configure our colors and fonts once in tailwind.config.js and then just use tailwind's classes.

rwfeather commented 2 years ago

Yeah, I agree. Tailwind as our theming layer seems good.

Also, FWIW I think sass already works in our current configuration, no work necessary. Tried it out earlier today and renaming main.css to main.scss had no issues, and we already are writing scss inside the Vue components.

So if we do run into something moving forward that can only be solved with sass variables/imports, I think we should be fine.