meltano / hub

The single source of truth for all Meltano plugins, including all available Singer Taps and Targets: https://hub.meltano.com
https://hub.meltano.com
50 stars 68 forks source link

Remove tap-amazon-mws after April 2024 when API is deprecated #998

Open pnadolny13 opened 2 years ago

pnadolny13 commented 2 years ago

I'm not 100% sure but it looks like https://hub.meltano.com/extractors/tap-amazon-mws/ is using a deprecated API that is replaced by the selling partners API https://hub.meltano.com/extractors/tap-amazon-sp.

How do we handle this situation? All of the variants look to be inactive and if the API is deprecated. I dont think theres harm in leaving it up but maybe at some point we hide it from the UI so we look a little more up to date.

pnadolny13 commented 1 year ago

The API stops being available on April 1, 2024 https://developer-docs.amazon.com/sp-api/page/migration-hub.

Knowing this I'd be in favor of keeping it around until then. Theres only 1 project showing as using it in telemetry but its totally possible that someone wants to use it until the day it gets shut off.

pnadolny13 commented 1 year ago

I refreshed the plugin definition and set a new variant as default https://github.com/meltano/hub/pull/1331.

I'm going to update this issue to remind us to deprecate this plugin after April 2024.