search

meltano / sdk

Write 70% less code by using the SDK to build custom extractors and loaders that adhere to the Singer standard: https://sdk.meltano.com
https://sdk.meltano.com
Apache License 2.0
94 stars 67 forks source link

change: Exception raised when input line is not a valid singer message should be more specific #1288

Closed edgarrmondragon closed 1 month ago

edgarrmondragon commented 1 year ago

The exception raised here (Exception) is too generic. A more concrete exception class would be nice

_Originally posted by @edgarrmondragon in https://github.com/meltano/sdk/pull/1287#discussion_r1053833567_

visch commented 1 year ago

Yes 💯, a good place to start for these if you want a list of them is in the target tests for postgres

stale[bot] commented 1 year ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

stale[bot] commented 1 month ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 month ago

This was done in https://github.com/meltano/sdk/commit/adcd9175d0d59d5b7a273985afd3b1216aac03ee