Open BuzzCutNorman opened 1 year ago
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen
label, or request that it be added.
Still relevant
Still relevant.
Singer SDK Version
0.24.0
Is this a regression?
Python Version
3.9
Bug scope
Taps (catalog, state, etc.)
Operating System
Windows
Description
If you setup Incremental replication to use a non datetime column as a
replcation-key
andstart_date
is set in themeltano.yml
then during the initial incremental run it will fail with a pyodbc conversion error.The issue seems to be in
_write_starting_replication_value
. The method doesn't currently check if the replication key coloumn is of type timestamp before assigning thestart_date
. I guess it could also check that the replication key is not of type numeric or integer.Possible fix:
Code