search

meltano / sdk

Write 70% less code by using the SDK to build custom extractors and loaders that adhere to the Singer standard: https://sdk.meltano.com
https://sdk.meltano.com
Apache License 2.0
94 stars 67 forks source link

Refactor "Singer interop" helpers to a public `singer-sdk.singer` module #208

Closed MeltyBot closed 1 month ago

MeltyBot commented 3 years ago

We should consider moving the Singer helpers and Singer interop classes/methods into their own public module, including functions for catalog and metadata in singer_sdk/helpers/_singer.py, added in !146, to a public module (stable and officially supported), and gather feedback from the broader Singer community.

This could be a step towards publishing our own Singer interop module down the road.

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/209, Originally created by @edgarrmondragon on 2021-09-03 16:32:21

MeltyBot commented 2 years ago

View 4 previous comments from the original issue on GitLab

tayloramurphy commented 1 year ago

@edgarrmondragon @aaronsteers is this actually being prioritized right now? I'm going to remove from the engineering board unless you feel it should be.

edgarrmondragon commented 1 year ago

@edgarrmondragon @aaronsteers is this actually being prioritized right now?

@tayloramurphy Not really. I think we're good for now with just https://github.com/meltano/sdk/pull/979.

stale[bot] commented 1 year ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 year ago

Still relevant. This is probably as easy as making singer_sdk._singerlib a public API in singer_sdk.singer.

stale[bot] commented 1 month ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 month ago

I don't think have a strong reason at the moment for making singer_sdk._singerlib public.