search

meltano / sdk

Write 70% less code by using the SDK to build custom extractors and loaders that adhere to the Singer standard: https://sdk.meltano.com
https://sdk.meltano.com
Apache License 2.0
94 stars 66 forks source link

[Feature]: Consider not using a source that requires authentication for "external" tests in CI #877

Closed edgarrmondragon closed 1 month ago

edgarrmondragon commented 2 years ago

Feature scope

Other

Description

Our "external" integration tests use Google Analytics and GitLab. This is fine to validate precisely authentication, but it also means that we have to manage secrets for these services in the repo settings.

Now, forks don't have access to these secrets, neither does dependabot (by default, can be copied verbatim to https://github.com/meltano/sdk/settings/secrets/dependabot) so we can't run the external tests pipeline on community-contributed PRs.

Ideally, we would an open source API application that we can start and seed data to as a docker container running in CI. We could safely pass hardcoded credentials to this local service.

A OSS product like listmonk.app or similar probably makes the most sense.

stale[bot] commented 1 year ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 year ago

Still relevant

stale[bot] commented 1 month ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 month ago

Arguably done by #2551