Geas: Try to honor italic/bold/underline formatting (patch included)

[GoogleCodeExporter]

This patch tries to make a reasonable attempt to map Geas styles to Glk styles.

With Glk, we have to use predefined styles, so we cannot always match the 
formatting that the game asks for. But honoring one font attribute is better 
than ignoring all of them.

Glk doesn't do underline at all, so I mapped it to reverse video. Which looks 
rather ugly, in my opinion, but then so does underline.

I removed the bold formatting from the room descriptions, since large blocks of 
text were printed in bold. This was both ugly and it drowned individual words 
that were also printed in bold.

Original issue reported on code.google.com by mthuu...@gmail.com on 7 Feb 2012 at 10:48

Attachments:

• format2.diff

[GoogleCodeExporter]

Original comment by bcressey@gmail.com on 8 Feb 2012 at 5:13

• Changed state: Accepted

[GoogleCodeExporter]

Thanks for these patches!

I would recommend using the default style_Subheader for bold text, versus 
setting a user style.

Also, if Geas supports style combinations (bold + italic) you can use 
style_Alert to achieve that.

Original comment by bcressey@gmail.com on 8 Feb 2012 at 5:22

[GoogleCodeExporter]

Geas has a separate boolean in its font state for bold, italic and underline. 
I'll have a look at the styles you suggested.

Original comment by mthuu...@gmail.com on 8 Feb 2012 at 9:58

[GoogleCodeExporter]

I updated the patch with your suggestions: style_Subheader for bold and 
style_Alert for bold + italic.

Original comment by mthuu...@gmail.com on 9 Feb 2012 at 3:02

Attachments:

• format2a.diff

[GoogleCodeExporter]

This issue was closed by revision r592.

Original comment by bcressey@gmail.com on 13 Feb 2012 at 5:56

• Changed state: Fixed