search

meltingice / CamanJS

Javascript HTML5 (Ca)nvas (Man)ipulation
http://camanjs.com
BSD 3-Clause "New" or "Revised" License
3.55k stars 404 forks source link

renderFinished isn't triggered with correct target #145

Open gregpsycle opened 10 years ago

gregpsycle commented 10 years ago

(this is with tip) the event is triggered on 1883 (of the full JS) as:

Event.trigger(this, "renderFinished");

But 'this' there is the Renderer, not the Caman instance. I think it should be 'this.c' (that's what the call to trigger 'processStart' uses a couple of functions further along.

The implication of this is that trying to listen for the renderFinished event with a specific instance (Caman.Event.listen(c, 'renderFinished', ...) isn't possible, as the comparison between the trigger-target and the callback-target will never succeed.

neon64 commented 10 years ago

This is happening to me too... Hopefully it might get fixed.