search

meltingice / CamanJS

Javascript HTML5 (Ca)nvas (Man)ipulation
http://camanjs.com
BSD 3-Clause "New" or "Revised" License
3.55k stars 404 forks source link

Added CORS support to CamanInstance.canvasLoaded() #58

Closed sandbochs closed 11 years ago

sandbochs commented 11 years ago

I think my previous pull was automatically closed when I reset my branch to HEAD. I guess the proper workflow is to branch again, merge new branch into old branch and push -f origin branch?

After implementing and refactoring a few times I think I have it down properly. Let me know if this is what you meant.

I didn't write tests, but I tried reverting a CamanInstance of three separate images:

same domain, no crossorigin attribute remote domain with no crossorigin attribute defaulted to "anonymous" remote domain with a crossorigin 'something' is recreated with 'crossorigin="something"'

Let me know what you think.

meltingice commented 11 years ago

Realized after merging that there were some issues with the code. Fixed them up, should be good now. Thanks!

sandbochs commented 11 years ago

I was looking over your changes and was wondering if the crossorigin attribute will be set to 'anonymous' if it was previously set to some other value.